DNM Debugging: Assert various read hold stuff #34325
Draft
+89
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
force-pushed
the
frontend-peek-SinceViolation-debugging
branch
from
10e7029 to
322e85e
Compare
ggevay
force-pushed
the
frontend-peek-SinceViolation-debugging
branch
2 times, most recently
from
11cf76f to
7c8dd4a
Compare
ggevay
force-pushed
the
frontend-peek-SinceViolation-debugging
branch
from
7c8dd4a to
63b4948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just debugging the
SinceViolationand thedataflow has an as_of not beyond the since of collectionin https://github.com/MaterializeInc/database-issues/issues/9593, adding a lot of DNM asserts.