[persist] Remove the Result wrapping from the legacy codec #34339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old, non-columnar Persist encoding returned row-by-row errors, but the expectation is that the schema checking for columnar data happens all at once and up front. Not only does this error path only matter for the increasingly small fraction of legacy data, but all callers were effectively unwrapping errors anyways. This commit switches to passing around data direcly instead of wrapping each key and value in a Result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old, non-columnar Persist encoding returned row-by-row errors, but the expectation is that the schema checking for columnar data happens all at once and up front. Not only does this error path only matter for the increasingly small fraction of legacy data, but all callers were effectively unwrapping errors anyways. This commit switches to passing around data direcly instead of wrapping each key and value in a Result.
Motivation
Drive-by improvement while looking into some
StorageCollections-related refactoring.Tips for reviewer
In case you're interested, the production codec impl is here. The only way this could throw errors is if the
ProtoSourceDatadecode returned an error, which would imply that the bytes themselves had been corrupted or that the proto had changed in a backwards-incompatible way.