Testing different console versions #34345
Open
+271
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
requested changes
Dec 4, 2025
Comment on lines
+44
to
+46
| # cloud-forward: newest version (index 0) (version in staging) | ||
| # cloud-current: the version released before the latest one (version in prod) | ||
| # cloud-backward: two versions back before the latest released version (version in staging) |
Contributor
There was a problem hiding this comment.
This is not correct I think. We can have the same version in staging and prod at some time.
| minor_versions = get_published_minor_mz_versions(newest_first=True, limit=5) | ||
|
|
||
| # Debug: Print minor versions | ||
| print(f"DEBUG: Minor versions (newest first): {[str(v) for v in minor_versions]}") |
Contributor
There was a problem hiding this comment.
Might want to remove the debug print
Comment on lines
+48
to
+50
| cloud_forward = minor_versions[0] if len(minor_versions) > 0 else None | ||
| cloud_current = minor_versions[1] if len(minor_versions) > 1 else None | ||
| cloud_backward = minor_versions[2] if len(minor_versions) > 2 else None |
Contributor
There was a problem hiding this comment.
You could also assert the length of versions.
|
|
||
| if version_str: | ||
| print(f"Docker image: materialize/materialized:{version_str}") | ||
| c.compose["services"]["materialized"]["image"] = f"materialize/materialized:{version_str}" |
Contributor
There was a problem hiding this comment.
This is not the correct way! It does not respect backwards-incompatible changes. This will fail when testing old versions at some point in the future.
The correct way is:
with c.override(Materialized(image=...)):
and then put the remaining code inside of that context, including the c.up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The console runs sql tests by running the
./mzcompose run defaultscript in CI and for local testing to test the sql queries in the console. Currently we only test against the latest version of Materialize but don't do any testing for previous, current and forward versions. This PR will let us pull the images for different versions and run console tests against these materialize images. Next steps would be to implement a CI job in console repo to test against different materialize versions.Future work : When the console repo is moved into the materialize repo then this script can be expanded to run a test that tests all the versions and pull down the docker images.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.