[repr types] eliminate noop costs (lowering impl) #34350
+52
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
varchar_to_textcast is functionally a noop, but exists to satisfy the typechecker:varchar(8)andvarcharandtextare different SQL types.But they are not different representation types---all of these will be
Datum::Stringat runtime. So: in MIR, we can eliminate this cast.This PR alters lowering (gated behind the feature flag
enable_cast_elimination) to not bother generatingvarchar_to_textwhen lowering HIR to MIR.Alternative implementation to #34348, which fails because the non-repr typechecker gets upset (and because I didn't rewrite the tests yet).
Both PRs will need to have only the repr typechecker running to avoid inconsistencies #34351.
Motivation
design doc: MIR typechecking using representation types #27239
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.