Skip to content

adapter: remove expensive confirm_leadership call #34355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −13
Draft

adapter: remove expensive confirm_leadership call #34355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/adapter/src/coord/appends.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,19 +445,6 @@ impl Coordinator {
advance_to,
} = self.get_local_write_ts().await;

// While we're flipping on the feature flags for txn-wal tables and
// the separated Postgres timestamp oracle, we also need to confirm
// leadership on writes _after_ getting the timestamp and _before_
// writing anything to table shards.
//
// TODO: Remove this after both (either?) of the above features are on
// for good and no possibility of running the old code.
let () = self
.catalog
.confirm_leadership()
.await
.unwrap_or_terminate("unable to confirm leadership");

let mut appends: BTreeMap<CatalogItemId, SmallVec<[TableData; 1]>> = BTreeMap::new();
let mut responses = Vec::with_capacity(validated_writes.len());
let mut notifies = Vec::new();
Expand Down