Skip to content

adapter: handle easy objects using catalog implications #34358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aljoscha wants to merge 2 commits into
base: main
Choose a base branch
from
+53 −44
Open

adapter: handle easy objects using catalog implications #34358

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a01a42
adapter: handle AddSecret and AlterSecret via catalog implications
aljoscha Nov 28, 2025
f8590a8
adapter: handle AddConnection via catalog implications
aljoscha Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/adapter/src/coord/catalog_implications.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,18 +360,18 @@ impl Coordinator {
)) => {
continual_tasks_to_drop.push((catalog_id, ct.cluster_id, ct.global_id()));
}
CatalogImplication::Secret(CatalogImplicationKind::Added(secret)) => {
tracing::debug!(?secret, "not handling AddSecret in here yet");
CatalogImplication::Secret(CatalogImplicationKind::Added(_secret)) => {
// No action needed: the secret payload is stored in
// secrets_controller.ensure() BEFORE the catalog transaction.
// By the time we see this update, the secret is already stored.
}
CatalogImplication::Secret(CatalogImplicationKind::Altered {
prev: prev_secret,
new: new_secret,
prev: _prev_secret,
new: _new_secret,
}) => {
tracing::debug!(
?prev_secret,
?new_secret,
"not handling AlterSecret in here yet"
);
// No action needed: altering a secret updates the payload via
// secrets_controller.ensure() without a catalog transaction,
// so we shouldn't see AlterSecret updates here.
Comment on lines +374 to +376
Copy link
Contributor

@teskje teskje Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth adding a soft assert or error log, so we can catch if this ever changes?

}
CatalogImplication::Secret(CatalogImplicationKind::Dropped(
_secret,
Expand Down