Skip to content

tests: Try disabling the benchmarking sys params #34363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
def- wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −15
Open

tests: Try disabling the benchmarking sys params #34363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions misc/python/materialize/mzcompose/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,21 @@

# Parameters which disable systems that periodically/unpredictably impact performance
ADDITIONAL_BENCHMARKING_SYSTEM_PARAMETERS = {
"enable_statement_lifecycle_logging": "false",
"persist_catalog_force_compaction_fuel": "0",
"statement_logging_default_sample_rate": "0",
"statement_logging_max_sample_rate": "0",
# Default of 128 MB increases memory usage by a lot for some small
# performance in benchmarks, see for example FastPathLimit scenario: 55%
# more memory, 5% faster
"persist_blob_cache_mem_limit_bytes": "1048576",
# This would increase the memory usage of many tests, making it harder to
# tell small memory increase regressions
"persist_blob_cache_scale_with_threads": "false",
# The peek response stash kicks in when results get larger, and it
# increases query latency. Which in turn makes benchmarking more
# unpredictable.
"enable_compute_peek_response_stash": "false",
# "enable_statement_lifecycle_logging": "false",
# "persist_catalog_force_compaction_fuel": "0",
# "statement_logging_default_sample_rate": "0",
# "statement_logging_max_sample_rate": "0",
# # Default of 128 MB increases memory usage by a lot for some small
# # performance in benchmarks, see for example FastPathLimit scenario: 55%
# # more memory, 5% faster
# "persist_blob_cache_mem_limit_bytes": "1048576",
# # This would increase the memory usage of many tests, making it harder to
# # tell small memory increase regressions
# "persist_blob_cache_scale_with_threads": "false",
# # The peek response stash kicks in when results get larger, and it
# # increases query latency. Which in turn makes benchmarking more
# # unpredictable.
# "enable_compute_peek_response_stash": "false",
}


Expand Down