Skip to content

Add in progress note to internal_certificate_spec #34364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Add in progress note to internal_certificate_spec #34364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/user/data/self_managed/materialize_crd_descriptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
{
"name": "internalCertificateSpec",
"type": "MaterializeCertSpec",
"description": "The cert-manager Issuer or ClusterIssuer to use for database internal communication.\nThe `issuerRef` field is required.\nThis currently is only used for environmentd, but will eventually support clusterd.",
"description": "The cert-manager Issuer or ClusterIssuer to use for database internal communication.\nThe `issuerRef` field is required.\nThis currently is only used for environmentd, but will eventually support clusterd.\nNot yet implemented.",
Copy link
Contributor

@kay-kim kay-kim Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh ... that "Not yet implemented" -- Is it referring to the clusterd part? Because it's in a standalone sentence ... it makes it sound like the whole thing is not yet implemented. Kind of like, if we had added a Deprecated afterwards ... it'd be more for the whole thing.

Copy link
Contributor

@kay-kim kay-kim Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ... actually, reading the description... exactly, what is not implemented?

"default": null,
"required": false,
"deprecated": false
Expand Down
1 change: 1 addition & 0 deletions src/cloud-resources/src/crd/materialize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ pub mod v1alpha1 {
/// The cert-manager Issuer or ClusterIssuer to use for database internal communication.
/// The `issuerRef` field is required.
/// This currently is only used for environmentd, but will eventually support clusterd.
/// Not yet implemented.
pub internal_certificate_spec: Option<MaterializeCertSpec>,
}

Expand Down