Skip to content

Avoid snapshot in ALTER SINK if the sink has made progress #34588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martykulma merged 3 commits into from
Dec 23, 2025
Merged

Avoid snapshot in ALTER SINK if the sink has made progress #34588

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
154b7ab
Avoid snapshot in ALTER SINK if the sink has made progress
martykulma Dec 19, 2025
564bd38
improve comment
martykulma Dec 23, 2025
250d19f
move snapshot determination to storage-controller
martykulma Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/storage-controller/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,15 @@ where
};
*cur_export = new_export;

// For `ALTER SINK`, the snapshot should only occur if the sink has not made any progress.
// This prevents unnecessary decoding in the sink.
// If the write frontier of the sink is strictly larger than its read hold, it must have at
// least written out its snapshot, and we can skip reading it; otherwise assume we may have
// to replay from the beginning.
// TODO(database-issues#10002): unify this with run_export, if possible
let with_snapshot = new_description.sink.with_snapshot
&& !PartialOrder::less_than(&new_description.sink.as_of, &cur_export.write_frontier);

let cmd = RunSinkCommand {
id,
description: StorageSinkDesc {
Expand All @@ -1597,7 +1606,7 @@ where
as_of: new_description.sink.as_of,
version: new_description.sink.version,
from_storage_metadata,
with_snapshot: new_description.sink.with_snapshot,
with_snapshot,
to_storage_metadata,
commit_interval: new_description.sink.commit_interval,
},
Expand Down