Skip to content

sql: add well-known protobuf types for CSR schema compilation #34630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bosconi wants to merge 4 commits into from
Closed

sql: add well-known protobuf types for CSR schema compilation #34630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca7584c
sql: add well-known protobuf types for CSR schema compilation
bosconi Dec 31, 2025
b93c093
test: add testdrive test for protobuf well-known types
bosconi Dec 31, 2025
9aa68c2
chore: fix formatting issues from cargo fmt
bosconi Dec 31, 2025
3058250
chore: fix bare URL in rustdoc comment
bosconi Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/sql/src/pure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ mod references;

pub mod mysql;
pub mod postgres;
mod protobuf;
pub mod sql_server;

pub(crate) struct RequestedSourceExport<T> {
Expand Down Expand Up @@ -2513,6 +2514,12 @@ async fn compile_proto(

// Compile .proto files into a file descriptor set.
let mut source_tree = VirtualSourceTree::new();

// Add well-known types (e.g., google/protobuf/timestamp.proto) to the source
// tree. These are implicitly available to protoc but are typically not
// registered in the schema registry.
protobuf::add_well_known_types(source_tree.as_mut());

for subject in iter::once(&primary_subject).chain(dependency_subjects.iter()) {
source_tree.as_mut().add_file(
Path::new(&subject.name),
Expand Down
Loading