Skip to content

Conversation

@bosconi
Copy link
Member

@bosconi bosconi commented Jan 13, 2026

Motivation

When using Protobuf with a CSR connection, schemas that import well-known types fail to compile.

MaterializeInc/rust-protobuf-native#29 added a function to add the types from the already vendored version of the protobuf source.

This PR adds calling of that new function to the database, along with a test.

This PR supersedes #34635.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Copy link
Member

@DAlperin DAlperin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % test pass. Thank you very much!

@bosconi bosconi merged commit 23c23cf into MaterializeInc:main Jan 13, 2026
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants