persist: move consolidator sorting to isolated runtime #34700
+171
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ConsolidationPart::from_encoded` function performs CPU-intensive sorting work that was previously running synchronously on the main runtime. This could cause runtime stalls that prevent heartbeat tasks from running, leading to persist reader lease expirations. This change adds `from_encoded_async` that spawns the sorting work on the IsolatedRuntime, following the pattern used for batch encoding. Changes: - Add `isolated_runtime` field to `Consolidator` struct - Add `from_encoded_async` method that sorts on isolated runtime - Update `unblock_progress` to use async version - Add manual Clone impl for StructuredSort (no K: Clone, V: Clone needed) - Update all callers to pass isolated_runtime Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The Consolidator's sorting operation can be CPU-intensive for large parts that need reconsolidation. When this runs on the main tokio runtime, it can block other tasks including the heartbeat task responsible for keeping reader leases alive.
Test plan
Generated with Claude Code