persist: add time-based yielding to compaction chunking #34701
+29
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chunk() method in the Consolidator can run for a long time when processing large numbers of updates, blocking the runtime and preventing heartbeat tasks from running. This change adds time-based yielding to the chunk iteration: - New config `compaction_yield_after_ms` (default 10ms) - chunk() now checks elapsed time periodically (every 1000 iterations) - Returns early if time threshold exceeded, allowing the outer loop to yield The caller can continue calling next_chunk() to process remaining data, with yield points between calls. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The chunk() method can run for a long time when processing large numbers of updates (up to compaction_yield_after_n_updates, default 100,000). Even with the count-based limit, processing many updates synchronously can block the runtime and prevent heartbeat tasks from running.
Test plan
Generated with Claude Code