Remove the old timestamp selection #34712
Open
+149
−513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the old timestamp selection, as discussed here: https://materializeinc.slack.com/archives/C08A62E0751/p1767794273757089?thread_ts=1764865885.225539&cid=C08A62E0751
The second commit updates a bunch of tests and fixes the error message when we don't find a suitable timestamp: Both the old and the new timestamp selection were relying on
generate_timestamp_not_valid_error_msg, but that doesn't work well for the new timestamp selection forAS OFqueries: the candidate comes out not as theAS OFtime, sowould regress from
to
which does not make sense: The
[]is the list of inputs that this timestamp is not valid for, so we can see that actually this timestamp is valid for all inputs. But the problem here is not that this timestamp is not valid for an input, but the problem is theAS OF, which is not mentioned by the error msg.So, the PR makes the error message print the constraints instead. It also tweaks the formatting of constraints a bit, to use more user-facing terminology, e.g., instead of
ComputeInputwe now sayIndexed input. So, now we have stuff like:Edit: I'm still fighting with a lot of annoying test output rewrites.