adapter,persist: make TCP keepalives configurable for CRDB connections #34731
+214
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and make it much more aggressive than the default two-hour interval.
This is required to make CRDB clients detect broken idle connections within a time frame of less than two hours.
With this PR, the repro in https://github.com/MaterializeInc/database-issues/issues/10019#issuecomment-3759914521 shows persist becoming functional again after 10s (the time until the first keepalive probe is sent) instead of after 2 hours.
Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/10019
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.