Skip to content

Conversation

@doy-materialize
Copy link
Contributor

@doy-materialize doy-materialize commented Jan 16, 2026

Motivation

i think this might be causing the cloud ci failures, somehow

this reverts #34530

Tips for reviewer

i really have no idea why this would cause problems, but from my testing, it seems extremely clear that this is causing problems somehow. i'd love to have an explanation for this, but the only place this seems to reproduce is in the cloud ci environment, i can't trigger failures locally at all/:

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@doy-materialize doy-materialize marked this pull request as ready for review January 16, 2026 20:12
@doy-materialize doy-materialize requested a review from a team as a code owner January 16, 2026 20:12
@def-
Copy link
Contributor

def- commented Jan 16, 2026

This is scary! What kind of symptoms are we seeing? We should get coverage for this in the Materialize CI.

Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns with reverting this if it solves a pain point.

@ggevay
Copy link
Contributor

ggevay commented Jan 17, 2026

Also discussed in this slack thread. It's ok to merge it temporarily, but in the long term this should really be a spawn_blocking, right?

Edit: And also in this slack thread: https://materializeinc.slack.com/archives/C08ACQNGSQK/p1768594520067049

(Edit 2: And originally here: https://materializeinc.slack.com/archives/CL68GT3AT/p1768588425534899?thread_ts=1768520601.725369&cid=CL68GT3AT )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants