fix: implement deep merge for helm_values to preserve nested defaults#76
Merged
bobbyiliev merged 1 commit intomainfrom Oct 5, 2025
Merged
fix: implement deep merge for helm_values to preserve nested defaults#76bobbyiliev merged 1 commit intomainfrom
bobbyiliev merged 1 commit intomainfrom
Conversation
bobbyiliev
force-pushed
the
fix-helm-values-merge
branch
from
8b6f1c0 to
406c533
Compare
def-
approved these changes
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform's merge() only performs shallow merging. When users override nested values like operator.clusters, it was wiping out sibling blocks like cloudProvider and image. Implemented proper deep merge for operator, storage, and tls blocks to preserve all default values while allowing granular user overrides.
Fixes #71