Follow ups after enabling swap #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-hunt-materialize
force-pushed
the
swap_follow_up_improvements
branch
from
20e1a23 to
2a31573
Compare
alex-hunt-materialize
changed the title
alex-hunt-materialize
force-pushed
the
swap_follow_up_improvements
branch
4 times, most recently
from
24c416d to
2ffe77a
Compare
alex-hunt-materialize
force-pushed
the
swap_follow_up_improvements
branch
from
2ffe77a to
3b45cae
Compare
* Renamed swap node group to materialize node group. * We now always enable the materialize node group. * Split up variables for different node groups. * Removed some vars that should never be modified. * We now always enable swap.
alex-hunt-materialize
force-pushed
the
swap_follow_up_improvements
branch
from
3b45cae to
17a63ac
Compare
bobbyiliev
approved these changes
Nov 25, 2025
Collaborator
bobbyiliev
left a comment
bobbyiliev
left a comment
There was a problem hiding this comment.
This looks great Alex! I'll start working on the GCP and Azure modules!
This was referenced Nov 25, 2025
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
5 tasks
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 27, 2025
Changed in MaterializeInc/terraform-aws-materialize#89 Test failures seen in https://buildkite.com/materialize/nightly/builds/14261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of follow ups after enabling swap.
Breaking changes: