[WIP] Add support for SQL Server #721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
requested review from
SangJunBak and
jubrad
and removed request for
a team
bobbyiliev
force-pushed
the
sql-server-support
branch
4 times, most recently
from
fcdffd0 to
f4db6fd
Compare
bobbyiliev
commented
Jun 30, 2025
Comment on lines
43
to
57
| "ssh_tunnel": IdentifierSchema(IdentifierSchemaParams{ | ||
| Elem: "ssh_tunnel", | ||
| Description: "The SSH tunnel configuration for the SQL Server database.", | ||
| Required: false, | ||
| ForceNew: false, | ||
| }), | ||
| "aws_privatelink": IdentifierSchema(IdentifierSchemaParams{ | ||
| Elem: "aws_privatelink", | ||
| Description: "The AWS PrivateLink configuration for the SQL Server database.", | ||
| Required: false, | ||
| ForceNew: false, | ||
| }), |
There was a problem hiding this comment.
Need to verify if SSH and PL connections are supported on the DB side.
bobbyiliev
commented
Jun 30, 2025
pkg/testhelpers/mock_scans.go
Outdated
Comment on lines
706
to
707
| LEFT JOIN mz_internal.mz_sqlserver_source_tables | ||
| ON mz_sources.id = mz_sqlserver_source_tables.id` |
There was a problem hiding this comment.
Unlike Postgres, those system tables are not present yet, I believe.
bobbyiliev
force-pushed
the
sql-server-support
branch
15 times, most recently
from
8b005b4 to
d999f24
Compare
bobbyiliev
force-pushed
the
sql-server-support
branch
from
d999f24 to
44a8801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #720
Worked on this over the weekend. Still need to do some edge case testing to make sure that I've not missed anything.