Fix: Accept the feedback for the code style.#19
Merged
wingio merged 1 commit intoMateriiApps:mainfrom Dec 27, 2024
LakeLab:improvement/FeedbackAccept
Merged
Fix: Accept the feedback for the code style.#19wingio merged 1 commit intoMateriiApps:mainfrom LakeLab:improvement/FeedbackAccept
wingio merged 1 commit intoMateriiApps:mainfrom
LakeLab:improvement/FeedbackAccept
Conversation
…ode to match with README.md
* A one-liner arrow for a multiline if seems weird, using blocks instead
* #16 (comment)
* Add a whitespace
* #16 (comment)
* Change back DragRefreshSample.kt code to match with README.md
X1nto
approved these changes
Dec 26, 2024
Contributor
Author
|
Hello, @wingio! Could you please help me review this PR and merge it? |
wingio
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for the acceptance of #16 PR's requested changes!
Thank you for your feedback! @X1nto
A one-liner arrow for a multiline if seems weird, using blocks instead
Add a whitespace
Change back DragRefreshSample.kt code to match with README.md
I rollback DragRefreshSample.kt code to the commit which is before #16 PR to match the sample code with README.md gif.
The gif in README.md is as below