Skip to content

Conversation

@KostLinux
Copy link
Contributor

@KostLinux KostLinux commented Mar 18, 2025

Description

The suggestion is to move swagger-related responses to a separate package to not mess up with code logic. They are models, with which I agree; however, they have nothing to do with code logic. Those response models are needed for swagger documents only.

Depends on #16 #15 due to my master branch is up to date

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas (optional)
  • I have made corresponding changes to the documentation (optional)
  • My changes generate no new warnings
  • I've performed/added tests/lints that prove my fix is effective or that my feature works (optional)

Before creating a pull request, check that all points under the checklist are done!

@Matrix278 Matrix278 self-requested a review March 19, 2025 09:18
@Matrix278 Matrix278 self-assigned this Mar 19, 2025
@Matrix278
Copy link
Owner

@KostLinux I would not make this, as the models not only for swagger, but actually used for error http responses. The only model I could see for using it currently is UserByIDResponseSwagger. But I guess it won't make much sense to put only this one model there, as I wanted to fix this issue with strfmt.UUID4 to remove it.

@KostLinux
Copy link
Contributor Author

Okay.. 🤔

@KostLinux KostLinux closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants