Skip to content

Use a single -- instead of needing double -- to separate commands #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryanjassal merged 1 commit into from
Nov 21, 2024
Merged

Use a single -- instead of needing double -- to separate commands #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ class ErrorPolykeyCLIUnexpectedError<T> extends ErrorPolykeyCLI<T> {
exitCode = sysexits.SOFTWARE;
}

class ErrorPolykeyCLISubprocessFailure<T> extends ErrorPolykeyCLI<T> {
static description = 'A subprocess failed to exit gracefully';
class ErrorPolykeyCLIChildProcessFailure<T> extends ErrorPolykeyCLI<T> {
static description = 'A child process failed to exit gracefully';
exitCode = sysexits.UNKNOWN;
}

Expand Down Expand Up @@ -196,7 +196,7 @@ export {
ErrorPolykeyCLIUncaughtException,
ErrorPolykeyCLIUnhandledRejection,
ErrorPolykeyCLIUnexpectedError,
ErrorPolykeyCLISubprocessFailure,
ErrorPolykeyCLIChildProcessFailure,
ErrorPolykeyCLIAsynchronousDeadlock,
ErrorPolykeyCLINodePath,
ErrorPolykeyCLIClientOptions,
Expand Down
4 changes: 2 additions & 2 deletions src/secrets/CommandEdit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class CommandEdit extends CommandPolykey {
};
const onError = (e: Error) => {
cleanup();
const error = new errors.ErrorPolykeyCLISubprocessFailure(
const error = new errors.ErrorPolykeyCLIChildProcessFailure(
`Failed to run command '${process.env.EDITOR}'`,
{ cause: e },
);
Expand All @@ -129,7 +129,7 @@ class CommandEdit extends CommandPolykey {
const onClose = (code: number | null) => {
cleanup();
if (code !== 0) {
const error = new errors.ErrorPolykeyCLISubprocessFailure(
const error = new errors.ErrorPolykeyCLIChildProcessFailure(
`Editor exited with code ${code}`,
);
reject(error);
Expand Down
Loading