Skip to content

Conversation

@aryanjassal
Copy link
Contributor

@aryanjassal aryanjassal commented Jan 28, 2025

Description

There have been a lot of changes in MatrixAI/Polykey#846 which require changes in Polykey CLI too. This PR makes those changes, ensuring the CLI remains up to date.

Issues Fixed

Tasks

  • 1. Update types to the tagged variants
  • 2. Remove usage of VaultsSecretsGet to prepare for its removal

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@aryanjassal aryanjassal self-assigned this Jan 28, 2025
@linear
Copy link

linear bot commented Jan 28, 2025

ENG-432

@aryanjassal
Copy link
Contributor Author

Forgot that working on an 'unreleased' polykey version will cause test failures. Oops.

@aryanjassal aryanjassal force-pushed the feature-eng-432-review-and-refactor-rpc-handlers-to-handle-cancellation branch from b61c9bf to 4415fbb Compare January 29, 2025 23:45
@aryanjassal aryanjassal force-pushed the feature-eng-432-review-and-refactor-rpc-handlers-to-handle-cancellation branch from 427b0cd to dd3bea9 Compare January 30, 2025 07:46
chore: streaming secret to file

deps: updated polykey to 1.17.4

fix: cleaned up secrets edit command

chore: enforced runtime type safety for some secrets commands
@aryanjassal aryanjassal force-pushed the feature-eng-432-review-and-refactor-rpc-handlers-to-handle-cancellation branch from 3b14472 to 720eff9 Compare January 30, 2025 23:41
@aryanjassal aryanjassal merged commit 51dfa4a into staging Jan 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Review and refactor RPC handlers to handle cancellation properly

4 participants