Skip to content

Conversation

@aryanjassal
Copy link
Contributor

@aryanjassal aryanjassal commented Feb 3, 2025

Description

Added secrets touch command to create a file if it doesn't exist, otherwise update the mtime if it does. The mtime is updated for directories too.

Issues Fixed

Tasks

  • 1. Add secrets touch
  • 2. Add tests for secrets touch

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@aryanjassal aryanjassal self-assigned this Feb 3, 2025
@aryanjassal
Copy link
Contributor Author

Note that merging this PR will introduce the secrets touch command, but not remove the secrets new command, as that command is responsible for copying the contents of a file on disk to a path on the vault. This behaviour will be covered by the secrets cp or secrets mv command, which will eventually make its way into PKCLI. Until then, there would be no real 1:1 command replacement.

@aryanjassal
Copy link
Contributor Author

All the tests are passing and the command seems to be working. I verified this with manual sanity checks. So, this will now be merged.

@aryanjassal aryanjassal merged commit f46aabc into staging Feb 4, 2025
22 checks passed
@CMCDragonkai
Copy link
Member

Hey checklist should be checked.

@CMCDragonkai
Copy link
Member

Note that merging this PR will introduce the secrets touch command, but not remove the secrets new command, as that command is responsible for copying the contents of a file on disk to a path on the vault. This behaviour will be covered by the secrets cp or secrets mv command, which will eventually make its way into PKCLI. Until then, there would be no real 1:1 command replacement.

Yes eventually new needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Implement secrets touch command

3 participants