Skip to content

New NodeID Doc Branch #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xrissoula wants to merge 21 commits into from
Closed

New NodeID Doc Branch #123

xrissoula wants to merge 21 commits into from

Conversation

@xrissoula
Copy link
Contributor

@xrissoula xrissoula commented Mar 10, 2025 •
edited
Loading

Description

Issues Fixed

Tasks

  • 1. Write initial documentation for Polykey Node IDs.
  • 2. Review for accuracy and consistency with the existing docs
  • 3. Format in Markdown with frontmatter and proper structure
  • 4. Ensure it follows the same structure as root-keypair-generation.md
  • 5. Final review and approval

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@xrissoula xrissoula added the documentation Improvements or additions to documentation label Mar 10, 2025
@xrissoula xrissoula requested a review from CMCDragonkai March 10, 2025 09:03
@xrissoula xrissoula self-assigned this Mar 10, 2025
@xrissoula
Copy link
Contributor Author

xrissoula commented Mar 10, 2025

hey @CMCDragonkai please review and merge if its ready.

@xrissoula
Copy link
Contributor Author

xrissoula commented Mar 11, 2025

@CMCDragonkai added the info you requested

@xrissoula xrissoula mentioned this pull request Mar 14, 2025
Closed
12 tasks
@xrissoula
Copy link
Contributor Author

xrissoula commented Mar 17, 2025

This PR is closed in favor of #135

@xrissoula xrissoula closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

Assignees

@xrissoula xrissoula

Labels

documentation Improvements or additions to documentation

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xrissoula