Conversation
CDeltakai
changed the title
Contributor
|
Hows the progress on this @CDeltakai ? |
fix: fixed rpc handler to decode input if id before passing it in
tegefaulkes
force-pushed
the
feature-eng-527-adding-agent-rpc-handlers-for-getting-sigchain-and-audit-data
branch
from
a04adea to
267d872
Compare
Member
|
So this gives us the possibility giving us sigchain related commands so we can finally inspect the sigchain? |
aryanjassal
suggested changes
Feb 26, 2025
Contributor
aryanjassal
left a comment
aryanjassal
left a comment
There was a problem hiding this comment.
Just some minor changes, otherwise looks good.
…sc tests for nodesClaimsGet
…m requestChainData that was causing a discovery test to fail due ot changes to how nodesClaimsGet worked
…ause we still need it (will reintroduce Discovery test failure)
aryanjassal
reviewed
Mar 5, 2025
…tility method in utils and replaced said parameters with utility method
Contributor
Author
|
It has been clarified that all seek parameters in relation to pagination should be by default inclusive, not exclusive. I'll have to go back and make changes to any RPC handlers with the incorrect assumption. |
…an order (it was the wrong way around) fix: fixed discovery test failure for updates previously discovered gestalts
…sed vertices to expect 2 calls instead of 3 on the 2nd attempt fix: changed NodesAuditEventsGet to not skip the first value anymore because we want seek to be inclusive. fixed its tests to match these changes
…ssed vertices in discovery test to be 3 (like before)
Contributor
Author
|
There is a test failure in Discovery.test.ts that for the moment can't be easily resolved. I've commented out the offending elements for now but will need to be addressed later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Fixed
Tasks
Final checklist