Integrate js-lint and fix any newfound linting errors

[CDeltakai]

Description

This PR tracks the integration of the js-lint package which will replace all current linting systems. It will also attempt to fix up any newfound errors that the new linter discovers.

Issues Fixed

• Fixes Polykey: Integrate js-lint #900

Tasks

• 1. Integrate js-lint
• 2. Fix any newfound errors found by js-lint

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[CDeltakai]

Removed await from a bunch of for loops that were looping over a non-async iterable which silences linter error @typescript-eslint/await-thenable and also slightly reduces overhead.

[CDeltakai]

Replace short-circuit call (func && await func(...)) with an explicit guard found in identities.test.ts and KeyRing.test.ts.
– Silences @typescript-eslint/no-unused-expressions (value of the && expression was unused)
– Makes the “call only if func exists” intent clearer and easier to debug
– Keeps behaviour identical while giving us room for future logging / error handling