Migrating to ESM #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Seems like something is wrong with |
Member
Author
|
ESM code can load CJS code. However they cannot destructure on import anymore. So for example, this is what is necessary for the Counter: import resourceCounter from 'resource-counter';
const { default: Counter } = resourceCounter; |
CMCDragonkai
force-pushed
the
feature-esm
branch
2 times, most recently
from
d64c7b3 to
9bbfec3
Compare
Member
Author
|
@tegefaulkes this requires a PR up to fast check. |
tegefaulkes
force-pushed
the
feature-esm
branch
from
9bbfec3 to
6f5eaca
Compare
tegefaulkes
force-pushed
the
feature-esm
branch
from
6f5eaca to
c09ad85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migrates to ESM.
Issues Fixed
Tasks
Final checklist