Add input file as parameter, auto-detecting image size#14
Open
Cirromulus wants to merge 8 commits intoMattFerraro:mainfrom
Open
Add input file as parameter, auto-detecting image size#14Cirromulus wants to merge 8 commits intoMattFerraro:mainfrom
Cirromulus wants to merge 8 commits intoMattFerraro:mainfrom
Conversation
Cirromulus
changed the title
Cirromulus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a command line parameter for the input image, fixing #2.
Will generate the loss images and .obj in the same folder with the same name as the original image.
Somewhat unrelated, I also added a dynamic number of passes, terminating when the loss compared to the previous run converges (arbitrarily when the improvement is only one percent).
This allows for more precision, if the algorithm is able to.
If this feature is not desired, I can add a separate PR for that and remove it from here.