Follow-up modernization: tests, cleanup, and CI improvements#18
Merged
MattShannon merged 6 commits intomasterfrom Mar 15, 2026
Merged
Follow-up modernization: tests, cleanup, and CI improvements#18MattShannon merged 6 commits intomasterfrom
MattShannon merged 6 commits intomasterfrom
Conversation
Replace direct x.strides assignment (deprecated in NumPy 2.4) with np.lib.stride_tricks.as_strided. Also re-enables the previously commented-out assertion. https://claude.ai/code/session_017xmjvL47SYtX11EZjQ2uSJ
Prevents pip from attempting to install on unsupported Python versions. Python 3.9 is the minimum supported by our deps (numpy>=1.26, scipy>=1.12). https://claude.ai/code/session_017xmjvL47SYtX11EZjQ2uSJ
- Delete orphaned .appveyor_update_version.ps1 - MANIFEST.in: include .pyx files instead of .c files in sdists, since Cython is now always used for building https://claude.ai/code/session_017xmjvL47SYtX11EZjQ2uSJ
Runs example.py (which has its own assertions) and example_spg.py as subprocess calls to catch any regressions. https://claude.ai/code/session_017xmjvL47SYtX11EZjQ2uSJ
…ecations - Add macOS to the test matrix (Linux + Windows + macOS) - Remove redundant pip install of cython/numpy/scipy (handled by pyproject.toml and requirements.txt via pip install -e .) - Run tests with -W error::DeprecationWarning to catch issues early https://claude.ai/code/session_017xmjvL47SYtX11EZjQ2uSJ
__array_interface__ reports strides as None for C-contiguous arrays. Normalize by filling in array.strides so stride changes are always detected. https://claude.ai/code/session_017xmjvL47SYtX11EZjQ2uSJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_array_memto normalizeNonestrides from__array_interface__, so stride changes on contiguous arrays are always detectedx.stridesassignment withnp.lib.stride_tricks.as_stridedpython_requires='>=3.9'tosetup.pyMANIFEST.into include.pyxinstead of.cfilesexample.py,example_spg.py)-W error::DeprecationWarning