Improve viewer hover highlighting and fix text rendering#199
Merged
MatthewMckee4 merged 1 commit intomainfrom Mar 5, 2026
Merged
Improve viewer hover highlighting and fix text rendering#199MatthewMckee4 merged 1 commit intomainfrom
MatthewMckee4 merged 1 commit intomainfrom
Conversation
…y cells - Replace separate yellow overlay highlight with in-place element re-rendering using brighter fill and bolder stroke, so highlights match element shape at all zoom levels - Expand spatial grid query_point to check 3×3 cell neighbourhood, eliminating hover misses near cell boundaries - Add edge tolerance to Polygon and GdsBox hit tests for more reliable hover - Fix text/node elements not rendering when they are the only elements in a spatial grid cell (point bboxes caused zero-size cell culling)
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query_pointto check a 3×3 neighbourhood of spatial grid cells, eliminating hover detection misses near cell boundaries3px / zoom) to Polygon and GdsBox hit tests for more reliable hover near edgesTest plan
cargo nextest run -p gdsr-viewer— all 134 tests pass