-
Notifications
You must be signed in to change notification settings - Fork 47
Changes to build and runit on Windows 10 with WSL (Ubuntu) #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(_MauiDotNetTfm);$(MauiPlatforms)</TargetFrameworks> | ||
| <TargetFrameworks>$(_MauiDotNetTfm)</TargetFrameworks> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reason for deleting the platform? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something like a mismatch from compiler, i can try to reproduce it and show you the error message There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In Visual Studio i got messages like that thats the Text, sry it's in German and everyone it's the same with another Project, you can scroll down there is one i have translated Issue in Graphics.Skia project during last operation: The value of the TargetFrameworks property is inconsistent between target frameworks. This property must be the same for NuGet restore to work properly. The value "netstandard2.1;netstandard2.0;net8.0;net8.0-gtk;;net7.0;" from the Debug|AnyCPU|netstandard2.1 configuration is used, other target frameworks may not select NuGet objects. You may need to reload the solution after resolving the issue. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any suggestions? |
||
| <Nullable>enable</Nullable> | ||
| <DefineConstants>$(DefineConstants);WEBVIEW2_MAUI</DefineConstants> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "profiles": { | ||
| "Controls.Sample.Gtk": { | ||
| "commandName": "Project" | ||
| }, | ||
| "WSL": { | ||
| "commandName": "WSL2", | ||
| "distributionName": "" | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,11 +9,16 @@ | |
| <Nullable>enable</Nullable> | ||
| <NoWarn>$(NoWarn);CA1307;CA1309;CS8603;CS8618;CS0162</NoWarn> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="CairoSharp" Version="3.24.24.95" /> | ||
| <PackageReference Include="GdkSharp" Version="3.24.24.95" /> | ||
| <PackageReference Include="PangoSharp" Version="3.24.24.95" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\Graphics\Graphics.csproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="$(TargetFramework.Contains('-gtk')) != 'true'"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reason for removing the platform specification here as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i have asked the same question here
For me it doesn't make sense to include GtkSharp if it isn't a -gtk project and also it would'nt compile There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In my opinion it should look like
There was n s missing in TargetFrameworks and it should be "== True", correct me if i'm wrong There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I looked into it on my end, and it seems that MSBuild is case-insensitive. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe i will try it, as i changed the workload i had read it is case sensitive but it should'nt != it should == |
||
| <PackageReference Include="GtkSharp" /> | ||
| <ItemGroup> | ||
| <PackageReference Include="GtkSharp" Version="3.24.24.95" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this change may cause CI/CD to cease functioning.
Therefore, I believe it would be preferable either to modify the CI/CD setup accordingly
maui-linux/.github/workflows/build-gtk.yml
Line 38 in 118de7c
or revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i changed it because VS 2022 would'nt like to install an old Android SDK or something