fix(control): exit stale UDP convoy after failed delete#27
Merged
Conversation
- add regression test for queue mapping deleted before convoy self-delete\n- exit convoy when queue map no longer points to current queue\n- include new convoy exit test in udp-taskpool TDD workflow
UDP TaskPool TDD Summary
Test Status
Suite Delta (time/op geomean)
Suite Status
Delta
|
DNS Benchmark Compare Summary
Suite Status
Suite Delta (time/op geomean)
|
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tryDeleteQueuefails after mapping was already removed/replacedTestConvoyExitsWhenQueueMappingDeletedBeforeSelfDeleteudp-taskpool-tdd.ymlrace test regex to include this regression guardRoot cause
When old convoy enters draining and another path deletes/replaces
key -> qfirst, old convoy's self-delete fails. Existing logic reset timer and continued, allowing stale convoy to loop outside map and accumulate.Validation
go test -v -race -timeout 30s ./control/... -run "Test(UdpTaskPool|CompareAndDelete|NoGoroutineLeak|ConvoyExitAfterFailedDelete|ConvoyExitsWhenQueueMappingDeletedBeforeSelfDelete|HighConcurrencyStress)"go test ./component/sniffing -run "TestIsLikelyQuicInitialPacket" -count=1