fix: resolve pg_collation error in table reflection with SQLAlchemy 2.0.45+#1393
Open
pcorpet wants to merge 2 commits intoMause:mainfrom
Open
fix: resolve pg_collation error in table reflection with SQLAlchemy 2.0.45+#1393pcorpet wants to merge 2 commits intoMause:mainfrom
pcorpet wants to merge 2 commits intoMause:mainfrom
Conversation
….0.45+ Override the _columns_query method in the DuckDB dialect to avoid querying pg_collation, which doesn't exist in DuckDB's catalog. Instead of querying pg_collation like SQLAlchemy's PostgreSQL dialect does, we return NULL for the collation field. This fixes issue Mause#1391 where table autoload would fail with "Catalog Error: Table with name pg_collation does not exist!" when using SQLAlchemy 2.0.45 or later. Related to SQLAlchemy issue #6511 which introduced pg_collation queries in the column reflection process. The fix: - Adds REGCLASS and OID type imports from sqlalchemy.dialects.postgresql.types - Implements _columns_query method that mirrors SQLAlchemy's PostgreSQL dialect - Modifies only the collation variable to return sql.null() instead of querying pg_collation - All other column reflection logic remains unchanged Tested with: - Simple table autoload - Tables with various column types - Full schema reflection via metadata.reflect()
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override the _columns_query method in the DuckDB dialect to avoid querying pg_collation, which doesn't exist in DuckDB's catalog. Instead of querying pg_collation like SQLAlchemy's PostgreSQL dialect does, we return NULL for the collation field.
This fixes issue #1391 where table autoload would fail with "Catalog Error: Table with name pg_collation does not exist!" when using SQLAlchemy 2.0.45 or later.
Related to SQLAlchemy issue #6511 which introduced pg_collation queries in the column reflection process.
The fix:
Tested with: