This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Use windowTitle instead of getModel in _cleaunup_panel #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone tries to setModel on not exported or somehow broken device, getModel returns empty string and TaurusDevicePanels is broken, so after trying to close the widget, it cannot find and remove it. Then, after reopening (even with restarted device) the panel, it finds broken widget again and doesn't try to open the new one. `Name` is also used for setting window title and in this case it's always the same.
|
Hi, we will try to reproduce the problem after preparing a test set up and will then get back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone tries to setModel on not exported or somehow broken device, getModel returns empty string and TaurusDevicePanels is broken, so after trying to close the widget, it cannot find and remove it. Then, after reopening (even with restarted device) the panel, it finds broken widget again and doesn't try to open the new one.
Nameis also used for setting window title and in this case it's always the same.