Add hide show pwd and fix edge cases

Author: Maxteabag

sqlit/domains/connections/providers/postgresql/base.py

@@ -2,7 +2,8 @@
 
 from __future__ import annotations
 
-from typing import Any
+from dataclasses import replace
+from typing import TYPE_CHECKING, Any
 
 from sqlit.domains.connections.providers.adapters.base import (
     ColumnInfo,
@@ -13,6 +14,9 @@
     TriggerInfo,
 )
 
+if TYPE_CHECKING:
+    from sqlit.domains.connections.domain.config import ConnectionConfig
+
 
 class PostgresBaseAdapter(CursorBasedAdapter):
     """Base class for PostgreSQL-compatible databases (PostgreSQL, CockroachDB).
@@ -41,6 +45,19 @@ def supports_cross_database_queries(self) -> bool:
     def default_schema(self) -> str:
         return "public"
 
+    def apply_database_override(self, config: ConnectionConfig, database: str) -> ConnectionConfig:
+        """Apply database override by modifying the connection config.
+
+        PostgreSQL databases are isolated and don't support cross-database queries.
+        To query a table in another database, we must connect to that database.
+        This returns a new config with the target database set.
+        """
+        endpoint = config.tcp_endpoint
+        if endpoint is None:
+            return config
+        new_endpoint = replace(endpoint, database=database)
+        return replace(config, endpoint=new_endpoint)
+
     def get_tables(self, conn: Any, database: str | None = None) -> list[TableInfo]:
         """Get list of tables from all schemas."""
         cursor = conn.cursor()

sqlit/domains/connections/ui/connection_focus.py

@@ -8,6 +8,7 @@
 from textual.widgets import Button, Input, OptionList, Select, TabbedContent
 
 from sqlit.domains.connections.ui.connection_form import ConnectionFormController
+from sqlit.domains.connections.providers.schema_helpers import FieldType
 from sqlit.domains.connections.ui.fields import FieldDefinition
 
 
@@ -50,6 +51,12 @@ def collect_tab_fields(tab_name: str) -> list[Any]:
                             collected.append(browse_btn)
                         except Exception:
                             pass
+                    if field_def.field_type == FieldType.PASSWORD:
+                        try:
+                            toggle_btn = self._screen.query_one(f"#toggle-password-{name}", Button)
+                            collected.append(toggle_btn)
+                        except Exception:
+                            pass
                 except Exception:
                     pass
             return collected

sqlit/domains/connections/ui/field_widgets.py

@@ -70,6 +70,27 @@ def build_field_container(
             self._field_definitions[field_def.name] = field_def
             container.compose_add_child(option_list)
             container.compose_add_child(Static("", id=f"error-{field_def.name}", classes="error-text hidden"))
+        elif field_def.field_type == FieldType.PASSWORD:
+            value = self._get_field_value(field_def.name) or field_def.default
+            input_widget = Input(
+                value=value,
+                placeholder=field_def.placeholder,
+                id=field_id,
+                password=True,
+            )
+            self._field_widgets[field_def.name] = input_widget
+            self._field_definitions[field_def.name] = field_def
+
+            password_row = Horizontal(classes="password-field-row")
+            password_row.compose_add_child(input_widget)
+            toggle_btn = Button(
+                "Show",
+                id=f"toggle-password-{field_def.name}",
+                classes="password-toggle-button",
+            )
+            password_row.compose_add_child(toggle_btn)
+            container.compose_add_child(password_row)
+            container.compose_add_child(Static("", id=f"error-{field_def.name}", classes="error-text hidden"))
         elif field_def.field_type in (FieldType.FILE, FieldType.DIRECTORY):
             value = self._get_field_value(field_def.name) or field_def.default
             input_widget = Input(

sqlit/domains/connections/ui/screens/connection.py

@@ -519,6 +519,14 @@ def on_button_pressed(self, event: Button.Pressed) -> None:
         if event.button.id and event.button.id.startswith("browse-"):
             field_name = event.button.id[7:]  # Remove "browse-" prefix
             self._on_browse_file(field_name)
+            return
+        if event.button.id and event.button.id.startswith("toggle-password-"):
+            field_name = event.button.id[len("toggle-password-") :]
+            widget = self._form.field_widgets.get(field_name)
+            if isinstance(widget, Input):
+                widget.password = not widget.password
+                event.button.label = "Hide" if not widget.password else "Show"
+                widget.focus()
 
     def _update_field_visibility(self) -> None:
         self._form.update_field_visibility(self._get_field_container)

sqlit/domains/connections/ui/screens/connection_styles.py

@@ -184,6 +184,24 @@
     width: 1fr;
 }
 
+.password-field-row {
+    width: 100%;
+    height: 1;
+}
+
+.password-field-row Input {
+    width: 1fr;
+}
+
+.password-toggle-button {
+    width: 6;
+    min-width: 6;
+    height: 1;
+    border: none;
+    margin-left: 1;
+    padding: 0;
+}
+
 .browse-button {
     width: 5;
     min-width: 5;

sqlit/domains/connections/ui/screens/password_input.py

@@ -6,8 +6,9 @@
 
 from textual.app import ComposeResult
 from textual.binding import Binding
+from textual.containers import Container, Horizontal
 from textual.screen import ModalScreen
-from textual.widgets import Input, Static
+from textual.widgets import Button, Input, Static
 
 from sqlit.shared.ui.widgets import Dialog
 
@@ -22,6 +23,8 @@ class PasswordInputScreen(ModalScreen):
     BINDINGS = [
         Binding("escape", "cancel", "Cancel", priority=True),
         Binding("enter", "submit", "Submit", show=False),
+        Binding("tab", "focus_next", "Next field", show=False, priority=True),
+        Binding("shift+tab", "focus_prev", "Previous field", show=False, priority=True),
     ]
 
     CSS = """
@@ -70,6 +73,24 @@ class PasswordInputScreen(ModalScreen):
         border: none;
         background-tint: $foreground 5%;
     }
+
+    #password-row {
+        width: 100%;
+        height: 1;
+    }
+
+    #password-row Input {
+        width: 1fr;
+    }
+
+    #password-toggle {
+        width: 6;
+        min-width: 6;
+        height: 1;
+        border: none;
+        margin-left: 1;
+        padding: 0;
+    }
     """
 
     def __init__(
@@ -106,17 +127,20 @@ def compose(self) -> ComposeResult:
         shortcuts: list[tuple[str, str]] = [("Submit", "<enter>"), ("Cancel", "<esc>")]
         with Dialog(id="password-dialog", title=self.title_text, shortcuts=shortcuts):
             yield Static(self.description, id="password-description")
-            from textual.containers import Container
-
             container = Container(id="password-container")
             container.border_title = "Password"
             with container:
-                yield Input(
-                    value="",
-                    placeholder="",
-                    id="password-input",
-                    password=False,
+                row = Horizontal(id="password-row")
+                row.compose_add_child(
+                    Input(
+                        value="",
+                        placeholder="",
+                        id="password-input",
+                        password=True,
+                    )
                 )
+                row.compose_add_child(Button("Show", id="password-toggle"))
+                yield row
 
     def on_mount(self) -> None:
         self.query_one("#password-input", Input).focus()
@@ -131,6 +155,25 @@ def on_input_submitted(self, event: Input.Submitted) -> None:
             self._log_submit("input_submitted", event.value)
             self.dismiss(event.value)
 
+    def on_button_pressed(self, event: Button.Pressed) -> None:
+        if event.button.id != "password-toggle":
+            return
+        input_widget = self.query_one("#password-input", Input)
+        input_widget.password = not input_widget.password
+        event.button.label = "Hide" if not input_widget.password else "Show"
+        input_widget.focus()
+
+    def action_focus_next(self) -> None:
+        input_widget = self.query_one("#password-input", Input)
+        toggle_btn = self.query_one("#password-toggle", Button)
+        if self.focused is input_widget:
+            toggle_btn.focus()
+        else:
+            input_widget.focus()
+
+    def action_focus_prev(self) -> None:
+        self.action_focus_next()
+
     def on_descendant_focus(self, event: Any) -> None:
         try:
             container = self.query_one("#password-container")

sqlit/domains/explorer/ui/tree/builder.py

@@ -504,6 +504,11 @@ def get_conn_label(config: Any, connected: bool = False) -> str:
                 dbs_node.data = FolderNode(folder_type="databases")
                 dbs_node.allow_expand = True
                 active_node.expand()
+                # Trigger async load of databases so they're visible after refresh
+                from . import loaders
+                loaders.add_loading_placeholder(host, dbs_node)
+                loaders.load_folder_async(host, dbs_node, dbs_node.data)
+                dbs_node.expand()
         else:
             add_database_object_nodes(host, active_node, None)
             active_node.expand()