Skip to content

fixing wrong filename written to md5 hash file#22

Closed
ccoenen wants to merge 9 commits intoMayeulC:masterfrom
ccoenen:md5-filename
Closed

fixing wrong filename written to md5 hash file#22
ccoenen wants to merge 9 commits intoMayeulC:masterfrom
ccoenen:md5-filename

Conversation

@ccoenen
Copy link

@ccoenen ccoenen commented Mar 2, 2019

Currently, when md5 files are being written, they contain

9e777f886ce454ddc32c6ff3f3d99908 *startrek_thenextgeneration_thespacebetween.epub.md5

but this is wrong. The filename that's being referenced does not END in .md5. Only the hash file does. The correct naming would be:

9e777f886ce454ddc32c6ff3f3d99908 *startrek_thenextgeneration_thespacebetween.epub

This PR fixes it.

@ccoenen
Copy link
Author

ccoenen commented Mar 2, 2019

I just realized that this includes commits I did not intend to include. Sorry!

@ccoenen ccoenen closed this Mar 2, 2019
@ccoenen ccoenen deleted the md5-filename branch March 5, 2019 07:42
@MayeulC
Copy link
Owner

MayeulC commented Mar 5, 2019

Do you want me to cherry-pick 0135dd2 ?

I can investigate the issue, unfortunately, I've been short on free time recently (alas, #20 has been sitting on the top of my priority list for some time...).

@ccoenen
Copy link
Author

ccoenen commented Mar 5, 2019

This is one of two Pull Requests that were merged into talonius' version of hb-downloader (see https://github.com/talonius/hb-downloader/pull/13 and https://github.com/talonius/hb-downloader/pull/14) I also proposed (and have finished) single product download, see https://github.com/talonius/hb-downloader/issues/12 for details.

I was not sure which of the two repositories is more active. I'm sorry for cross-posting to both, that was probably more work for everyone involved. Feel free to cherry-pick any of the thing that you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants