Open
Conversation
Add more tests for the API and the configuration parser. The tests are still quite basic, but begin to exercise more code.
This prepares the introduction of a setup.py file and makes things neater.
Many thanks to Stefan Zink (@zink-chimaera) in MayeulC#11
This commit will be squashed when merging with master
The Humble Trove support is now properly wired in, and behaves just like the other gamekeys. Tested for listing products and URLs, not for downloading yet.
Both are now aware of the lxml dependency
It stills needs to be in the loop as the item_type subparser is created there.
Unfortunately, the option does not play well with the next positionnal arguments for now.
The old configuration forced to download the games for all the platforms by override the configuration Now we can define the platform that we want. Defining --platform in the commandline will only change this platform to true We cannot use --platform and --keys together yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I used as basis your poc-trove branch and #20
I'm not sure it make a big change but so I was sure I had the latest possible update.
I use the chunk api page to grab all the games informations and we stop when we have "[]" as result.
For the rest I just did few adaptation related to the informations I grab from the API.
I changed the configuration because it looks like it took all platform by default same if my configuration file was set only for Linux. I think it was more logical to complete the configuration file instead to replace it but feel free to changed it back if needed.