Skip to content

Improve unit tests#9

Closed
MayeulC wants to merge 5 commits intonextfrom
wip-CI
Closed

Improve unit tests#9
MayeulC wants to merge 5 commits intonextfrom
wip-CI

Conversation

@MayeulC
Copy link
Owner

@MayeulC MayeulC commented May 8, 2018

No description provided.

@MayeulC MayeulC added the Do not merge PR The pull request is here to be checked against the current codebase by CI and other tools label May 8, 2018
@coveralls
Copy link

coveralls commented May 8, 2018

Pull Request Test Coverage Report for Build 27

  • 44 of 60 (73.33%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+17.4%) to 58.084%

Changes Missing Coverage Covered Lines Changed/Added Lines %
setup.py 0 5 0.0%
humble_downloader/init.py 24 35 68.57%
Totals Coverage Status
Change from base Build 11: 17.4%
Covered Lines: 485
Relevant Lines: 835

💛 - Coveralls

@MayeulC MayeulC added the rebase-needed Need to rebase on the next branch before merging label Jun 18, 2018
Add more tests for the API and the configuration parser.
The tests are still quite basic, but begin to exercise more code.
This prepares the introduction of a setup.py file and makes things neater.
Many thanks to Stefan Zink (@zink-chimaera) in
#11
@MayeulC MayeulC changed the base branch from master to next September 16, 2018 18:13
@MayeulC
Copy link
Owner Author

MayeulC commented Sep 16, 2018

This PR fell too far behind, merging in favor of #15

@MayeulC MayeulC closed this Sep 16, 2018
@MayeulC MayeulC deleted the wip-CI branch January 6, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge PR The pull request is here to be checked against the current codebase by CI and other tools rebase-needed Need to rebase on the next branch before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants