Skip to content

Split test_psa_compliance.py #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 30, 2025
Merged

Split test_psa_compliance.py #209

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3008a4a
Put the command line entry point in a function
gilles-peskine-arm Sep 11, 2025
26cb1a1
Move the bulk of test_psa_compliance.py to a module
gilles-peskine-arm Sep 11, 2025
43c6cbc
Move branch-dependent defaults to the calling script
gilles-peskine-arm Sep 11, 2025
4ff6a49
Support applying a patch to the compliance suite
gilles-peskine-arm Sep 11, 2025
af6b189
Teach crypto_knowledge the categories of SP800_100 and SPAKE2P algori…
gilles-peskine-arm Sep 11, 2025
565b4c3
Skip all knowledge of SPAKE2+ keys for now
gilles-peskine-arm Sep 11, 2025
b4035db
Fix [] used as a default argument value (mutable default values are d…
gilles-peskine-arm Sep 12, 2025
954783c
macro_collector: be stricter about unusual macros
gilles-peskine-arm Sep 12, 2025
ca98305
Treat xxx_HAS_xxx as not a constructor, like xxx_IS_xxx etc.
gilles-peskine-arm Sep 12, 2025
1295140
Read patch files instead of taking a single patch as input
gilles-peskine-arm Sep 12, 2025
088a99e
Allow framework and consuming branch to have Python scripts with the …
gilles-peskine-arm Sep 12, 2025
581da21
Allow patch files to have trailing whitespace
gilles-peskine-arm Sep 12, 2025
aebb1fa
Sort patch files for reproducibility
gilles-peskine-arm Sep 12, 2025
44ea713
Simplify passing a file to subprocess stdin
gilles-peskine-arm Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/mbedtls_framework/psa_compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def main(psa_arch_tests_ref: str,
expected_failures_list = expected_failures

if args.patch_directory:
patch_files = glob.glob(os.path.join(args.patch_directory, '*.patch'))
patch_file_glob = os.path.join(args.patch_directory, '*.patch')
patch_files = sorted(glob.glob(patch_file_glob))
Comment on lines +181 to +182
Copy link
Contributor

@bensze01 bensze01 Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This allows users to pass a patch_directory containing literal glob characters, which might lead to unexpected results.

glob.glob also silently ignores non-existent patch directories

Something like

patch_files = sorted(pathlib.Path(patch_directory).glob('*.patch'))

Would allow us to separate the glob from the user input

else:
patch_files = []

Expand Down