Skip to content

all.sh: fail if a file is missing on a "not grep ..." line #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilles-peskine-arm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

all.sh: fail if a file is missing on a "not grep ..." line #268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
499674d
all.sh: fail if a file is missing on a "not grep ..." line
gilles-peskine-arm Jan 9, 2026
076016b
Support piping into not_grep
gilles-peskine-arm Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions scripts/all-core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ pre_setup_keep_going () {
*test*) true;; # make test, tests/stuff, env V=v tests/stuff, ...
*make*check*) true;;
"grep "*) true;;
"not_grep "*) true;;
"[ "*) true;;
"! "*) true;;
*) false;;
Expand Down Expand Up @@ -780,9 +781,45 @@ pre_setup_keep_going () {
}
}

## not_grep [GREP_OPTION...] REGEXP FILE[...]
## Assert that none of the files contains a match for REGEXP.
## Errors such as a missing file are also assertion failures.
## If the assertion fails, print an error and consider the test case
## to be failed.
not_grep () {
#set -x
declare ret=0
grep -H "$@" || ret=$?
if [[ $ret -eq 0 ]]; then
# A match was found, and displayed on stdout.
# This is a test failure.
report_failed_command="not_grep $*"
false
unset report_failed_command
elif [[ $ret -ne 1 ]]; then
# If grep exited with error code 1, grep ran find and found that
# there were no matches, which means the assertion is true.
# If grep exited with an error code >=2, then something went
# wrong, probably a missing file (or e.g. a command syntax error).
# grep already printed an error message, so we just need to assert
# the condition and the ERR trap will mark the test case as failed.
# But make sure that the failure report indicates the grep command.
report_failed_command="not_grep $*"
(exit $ret)
unset report_failed_command
fi
}

# '! true' does not trigger the ERR trap. Arrange to trigger it, with
# a reasonably informative error message (not just "$@").
not () {
# "not grep" is fragile and should not be used.
# https://github.com/Mbed-TLS/mbedtls-framework/issues/266
if [ "$1" = "grep" ]; then
shift
not_grep "$@"
return
fi
if "$@"; then
report_failed_command="! $*"
false
Expand Down