Framework support for the pqcp driver #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
priority-high
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
6 tasks
We only look at symbols in the library, so don't bother building tests. No semantic change. Signed-off-by: Gilles Peskine <[email protected]>
Use a typed namespace instead of a dictionary with heterogenously typed values. No semantic change. Signed-off-by: Gilles Peskine <[email protected]>
I needed that to understand how the data is represented (str vs Match, list vs set vs tuple, ...). No semantic change. Signed-off-by: Gilles Peskine <[email protected]>
It's both clearer and faster. No semantic change. Signed-off-by: Gilles Peskine <[email protected]>
The pattern for internal macros was weird, in part, because of the unusual short names we use in bignum code. Make the pattern stricter, but add an exception mechanism. Declare an exception for those bignum names, but allow them only in bignum code. Signed-off-by: Gilles Peskine <[email protected]>
The mldsa-native and mlkem-native headers use preprocessor tricks to construct identifiers. We can't recognize those. So f a symbol found in the binary is in the expected sub-namespace for those parts of the library, allow it to be undeclared. Make the exception general enough for mldsa-native (needed now) and mlkem-native (needed soon). Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
valeriosetti
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_names.pyabout pqcp peculiarities.PR checklist