Add informative pipeline step labels #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
enhancement
gen_docker_jobs_foreach and gen_node_jobs_foreach were last used for mbed-crypto only. They became unused when we removed code that was specific to mbed-crypto, but we didn't notice at the time. Signed-off-by: Gilles Peskine <[email protected]>
all.sh has supported --list-components since 2.17.0 and 2.16.10. We don't need a fancy message for antique branches anymore: the exception from the all.sh call returning a nonzero status will do. Signed-off-by: Gilles Peskine <[email protected]>
Many sh or bat pipeline steps have an uninformative label. Groovy uses
the script as a label by default, but this is uninformative when the
script is something like "./steps.sh", and it's unreadable or
truncated when the script is very long. In such cases, use an
informative label, containing the job name.
In particular, this makes it possible to quickly search for the
execution of a given all.sh component in the Jenkins pipeline view:
search for "steps.sh #${job_name}", e.g.
"steps.sh #all_u16-test_clang_opt".
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
dev/gilles-peskine-arm/pipeline-labels
branch
from
7e63a91 to
055fabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put informative labels on shell steps like
./steps.sh. This makes it easier to locate interesting pipeline steps in the pipeline view.I also removed some obsolete code that I happened to notice. These removals are unrelated, except inasmuch they meant there were fewer sh steps to consider for labeling.
Test jobs on 7e63a91:
Status: so far the jobs are running fine, but:
The
labelparameter is listed in the documentation but apparently our version of the relevant plugin is too old (Pipeline: Nodes and Processes < 2.28). Back to the drawing board.