Skip to content

Conversation

rgqsch
Copy link

@rgqsch rgqsch commented Oct 1, 2025

Description

New code based on an older PR, fixed to latest coding styles.
This will add a challenge password to the CSR which might be needed by some SCEP servers

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

Ricardo Schoof added 4 commits October 1, 2025 08:48
Signed-off-by: Ricardo Schoof <[email protected]>
Signed-off-by: Ricardo Schoof <[email protected]>
Signed-off-by: Ricardo Schoof <[email protected]>
@rgqsch rgqsch changed the title Add challenge password to CSR Add challenge password to CSR Development Oct 1, 2025
@mpg mpg added enhancement component-x509 size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Oct 2, 2025
@mpg
Copy link
Contributor

mpg commented Oct 3, 2025

Hi and thanks for your contribution!

New code based on an older PR, fixed to latest coding styles.

Thanks for the update! Could you provide a link to the older PR? In case it already had some review history.

@rgqsch
Copy link
Author

rgqsch commented Oct 5, 2025

Hi and thanks for your contribution!

New code based on an older PR, fixed to latest coding styles.

Thanks for the update! Could you provide a link to the older PR? In case it already had some review history.

There were 2 old PR, those were never merged (#7843 and #7444 ). This is a complete rewrite trying to be more generic:
In mbedtls_x509write_csr adding a generic attributes field, in stead of a dedicated csr_password field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-x509 enhancement priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants