Reject high-tag-number ASN.1 tags in mbedtls_asn1_get_tag() #10510
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hardens ASN.1 tag parsing by explicitly rejecting high-tag-number tags in mbedtls_asn1_get_tag(). If the low 5 bits of the first identifier octet are 0x1F, the function now returns MBEDTLS_ERR_ASN1_UNEXPECTED_TAG immediately, rather than proceeding. This makes the function’s behavior aligned with its existing assumption of single-octet tags, avoids attempting to parse unsupported encodings, and improves robustness and clarity. There is no change to behavior for valid single-octet tags; only inputs using the long-form tag encoding are affected.
PR checklist