Skip to content

Conversation

juhaylinen
Copy link

Description

Backport of #9294

PR checklist

  • changelog not required
  • 3.6 backport not required
  • 2.28 backport not required
  • tests not required

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review component-test Test framework and CI scripts size-xs Estimated task size: extra small (a few hours at most) priority-medium Medium priority - this can be reviewed as time permits labels Jun 21, 2024
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01
Copy link
Contributor

Is this missing the framework update?

Python's argparse library, by default, allows shortening of command
line arguments. This can introduce silent failures when shortened
commands are used and another command is added to the script which
uses that name.

[Backport 3.6] Backport of PR 9294

Signed-off-by: Juha Ylinen <[email protected]>
Fix indentation error in scripts/config.py

Signed-off-by: Juha Ylinen <[email protected]>
@juhaylinen
Copy link
Author

Rebased and added framework update

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport, LGTM

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports needs-work and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review approved Design and code approved - may be waiting for CI or backports labels Mar 13, 2025
@gilles-peskine-arm
Copy link
Contributor

A lot of scripts have moved to https://github.com/Mbed-TLS/mbedtls-framework now. Those are unified between the development and 3.6 branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-test Test framework and CI scripts needs-work priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)

Projects

Status: Has Approval

Development

Successfully merging this pull request may close these issues.

3 participants