-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[Backport 3.6] Disable allow_abbrev from Python scripts using argparse #9295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mbedtls-3.6
Are you sure you want to change the base?
[Backport 3.6] Disable allow_abbrev from Python scripts using argparse #9295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this missing the framework update? |
Python's argparse library, by default, allows shortening of command line arguments. This can introduce silent failures when shortened commands are used and another command is added to the script which uses that name. [Backport 3.6] Backport of PR 9294 Signed-off-by: Juha Ylinen <[email protected]>
Fix indentation error in scripts/config.py Signed-off-by: Juha Ylinen <[email protected]>
Signed-off-by: Juha Ylinen <[email protected]>
90786b4
to
b0d070f
Compare
Rebased and added framework update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faithful backport, LGTM
A lot of scripts have moved to https://github.com/Mbed-TLS/mbedtls-framework now. Those are unified between the development and 3.6 branches. |
Description
Backport of #9294
PR checklist