-
Notifications
You must be signed in to change notification settings - Fork 30
Fix composer packages to pass twig linter #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@melroy89 looks like our ci/cd images need to be updated to include the php |
|
I'd vote for including a twig linter :) |
|
I updated the Docker CI image and tagged it as v1.2.0. |
This reverts commit 49b00f7.
fcf4413 to
3a2c6e7
Compare
Add XSL for PR: MbinOrg/mbin#1016
|
Docker file changes are merged to main via: #1078. We can later dive deeper why this is still giving errors. |
|
This PR is stale because it has been open 40 days with no activity. |
|
composer.lock has too many conflicts, not doing to fix that manually.. |
|
This PR is stale because it has been open 40 days with no activity. |
|
This PR is stale because it has been open 40 days with no activity. |
# Conflicts: # .github/workflows/action.yaml # composer.json # composer.lock # docker/Dockerfile # docs/02-admin/01-installation/01-bare_metal.md
|
We now have a twig linter again ^^ |
|
But I don't know if the PHP xsl extension is still required or not. |
I don't know why he would add this as well.. He added it to the production docker image (so not the dockerfile for ci/cd). and the production guide for bare metal. I think twig linting is unrelated to production dependencies. |
|
It also stated incorrectly that:
But that was clearly not the case, is our CI/CD image is located at: https://github.com/MbinOrg/mbin/blob/main/ci/Dockerfile You got the linter working without changing this Dockerfile. Meaning lets remove this |
Fixes:

@melroy89 maybe we should add
php bin/console lint:twigto our CI/CD checks? https://symfony.com/doc/current/templates.html#linting-twig-templates