Skip to content

Fix signup notifications for deleted accounts #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BentiGorlich merged 2 commits into from
Jan 14, 2025
Merged

Fix signup notifications for deleted accounts #1355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
140576d
Fix notifications for deleted accounts
BentiGorlich Jan 7, 2025
9553975
Merge branch 'main' into fix/signup-notifications-for-deleted-accounts
BentiGorlich Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/MessageHandler/Notification/SentNewSignupNotificationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ public function doWork(MessageInterface $message): void
if (!$user) {
throw new UnrecoverableMessageHandlingException('user not found');
}
$this->signupNotificationManager->sendNewSignupNotification($user);

if (!$user->isAccountDeleted() && !$user->isSoftDeleted() && null === $user->markedForDeletionAt) {
// only send notifications for new accounts if the account is not deleted,
// this is necessary because we create dummy accounts to block the username when an account is deleted
$this->signupNotificationManager->sendNewSignupNotification($user);
}
}
}