Skip to content

Add user ban and suspension lists to admin panel#995

Merged
20 commits merged intomainfrom
new/add_ban_and_suspension_lists_to_admin_panel
Aug 5, 2024
Merged

Add user ban and suspension lists to admin panel#995
20 commits merged intomainfrom
new/add_ban_and_suspension_lists_to_admin_panel

Conversation

@ghost
Copy link

@ghost ghost commented Aug 5, 2024

Add user inactive, suspension, and ban lists for easy admin review under the admin panel. Removes button indicators, I don't think the 2FA indicator adds any value, so I did not make a page/filter for it.

image

@ghost ghost added the enhancement New feature or request label Aug 5, 2024
@ghost ghost added this to the v1.8.0 milestone Aug 5, 2024
@ghost ghost self-assigned this Aug 5, 2024
@ghost ghost marked this pull request as draft August 5, 2024 01:10
@ghost ghost marked this pull request as ready for review August 5, 2024 15:19
@ghost ghost requested review from BentiGorlich, jwr1 and melroy89 August 5, 2024 15:19
BentiGorlich

This comment was marked as resolved.

@BentiGorlich
Copy link
Member

I actually think that it would be better if this was a dropdown value which filters stuff, more like the entry filters work. That could be expanded in the future with sort options, more information, ip-address filter or something like that

@BentiGorlich
Copy link
Member

Its great either way though (already deleted like 12 users who never verified their account :D)

@ghost
Copy link
Author

ghost commented Aug 5, 2024

I actually think that it would be better if this was a dropdown value which filters stuff, more like the entry filters work. That could be expanded in the future with sort options, more information, ip-address filter or something like that

i thought about that initially, its the crazy route names that result from multiple dropdowns that made me not do that... but its a fair point

@ghost ghost marked this pull request as draft August 5, 2024 17:05
@ghost ghost marked this pull request as ready for review August 5, 2024 17:53
@jwr1
Copy link
Member

jwr1 commented Aug 5, 2024

I actually think that it would be better if this was a dropdown value which filters stuff, more like the entry filters work. That could be expanded in the future with sort options, more information, ip-address filter or something like that

i thought about that initially, its the crazy route names that result from multiple dropdowns that made me not do that... but its a fair point

Couldn't you just use query params for that?

@ghost
Copy link
Author

ghost commented Aug 5, 2024

i added some slight adjustments to not show the table header if there are no users matching the conditions:

image

@ghost ghost enabled auto-merge (squash) August 5, 2024 20:27
@ghost ghost merged commit 4e7ea2f into main Aug 5, 2024
@ghost ghost deleted the new/add_ban_and_suspension_lists_to_admin_panel branch August 5, 2024 20:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants