Merged
Conversation
Fix missing normalization by 1/sqrt(2).
Use `permute()` to reflect the final step in the QFT circuit.
Owner
|
You are right about the normalization. I think in the book it was omitted for clarity of the point that was made and probably mentioned in the text. The final permutations are of course not necessary and no one would actually implement them on quantum hardware but for display purposes, I guess why not! |
Owner
|
Thank you! I will update the corresponding readme in a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State normalization should not be omitted, but the final swaps is more of a nice-to-have (the permutation looks pretty!).